-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define or forbid human readable exchange-id
#87
Comments
if you have a GET for /exchanges and are authorized i would assume you get a list of supported workflows, names, descriptions based on auth - I am working on a PR for this on VC-API |
Is there a better issue or PR to track this against? |
related most strongly to this |
Seems blocked by VC-API change set negotiations. |
Unassigning myself, as we just decided to wait with this. |
I don't intend to support the proposed API changes. |
My impression is that we have I propose that this flexibility is already allowed in this spec, and that these breaking changes should not be applied.
|
Someone else but Transmute needs to comment on this, pls. We are not planning on impl these APIs. |
ping @mprorock |
VC API defines an exchanges API, our goal on the traceability interop API is to be a superset of the VC-API, and as such we should support |
Should this be IRIs instead of UUIDs? IRIs are still unique. But would allow us to point to workflow definitions. For example:
|
we don't need to change anything to make them IRIs... they are already supposed to be IRIs given we are using JSON-LD. we might need to relax "MUST" statements in the profile that speak to UUIDs @nissimsan this comment is also a bit confusing on this issue, since this issue is about changes the vc-api has been making to:
... AFAIK those new endpoints have no tests. |
Yes, if I remember the conversation correctly this was the essential part. |
Proposal for resolution:
|
As far as I can tell nowhere in the spec do we actually have this "MUST" suggested in this issue. So I agree we can just go ahead and close this ticket. |
@OR13, are you okay to close this? |
I'm good to close this, not planning to implement at this time. |
consider:
POST /exchanges/credential-refresh
POST /exchanges/definition-oil-import-from-ca
POST /exchanges/definition-steel-import-from-mx
vs
POST /exchanges/urn:uuid:123
is guessable names a security issue?
if we support a single human readable name, does that mean we support all the other ones?
where is the registry for human readable "workflow definition names" maintained.
The text was updated successfully, but these errors were encountered: