Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflowId should be id in posted and returned workflow configuration #393

Open
dlongley opened this issue Jun 18, 2024 · 1 comment
Open
Assignees
Labels
ready for PR Issue ready to be resolved via a Pull Request

Comments

@dlongley
Copy link
Contributor

When creating a workflow, the configuration for that workflow may include, optionally, the ID for that workflow under the property id. The bug currently says that property is workflowId and it should be changed to id:

workflowId:

Similarly, the spec currently says that workflowId will be optionally returned, when the entire config can be optionally returned, which will include the workflow ID in the id property of the configuration object (just like how it can be optionally posted using that property).

@msporny
Copy link
Contributor

msporny commented Jul 30, 2024

The group discussed this on the 2024-07-30 telecon:

There seems to be a typo that needs to be fixed in the specification.

A PR should be raised to fix the typo.

@msporny msporny added the ready for PR Issue ready to be resolved via a Pull Request label Jul 30, 2024
@PatStLouis PatStLouis self-assigned this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for PR Issue ready to be resolved via a Pull Request
Projects
None yet
Development

No branches or pull requests

3 participants