Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly allow arbitrary request content to the identity assertion endpoint #443

Closed
bvandersloot-mozilla opened this issue Feb 16, 2023 · 4 comments

Comments

@bvandersloot-mozilla
Copy link
Collaborator

We kind of already allow this via the nonce, however it could be useful to codify this more explicitly. Especially as this would allow inclusion of scopes being requested without having to smuggle them in via the URL of the auth endpoint or in the nonce.

I discussed something related to this in fedidcg/proposals#3 but it could be adapted here. I'll add a comment with a general shape of the proposal.

@bvandersloot-mozilla
Copy link
Collaborator Author

This would entail:

  1. Adding a field to IdentityProviderConfig, USVString assertion_request;
  2. Modifying fetch an identity assertion to append to |requestBody| "&config_request=" and |config|'s assertion_request.

Overall this change is quite small and does not change the security properties. Names are only suggestions.

@samuelgoto
Copy link
Collaborator

@cbiesinger @bvandersloot-mozilla I'm wondering if we could/should make this a duplicate of https://github.com/fedidcg/FedCM/issues/556? wdyt?

@cbiesinger
Copy link
Collaborator

sgtm

@samuelgoto
Copy link
Collaborator

Ok, @bvandersloot-mozilla I'm going to mark this as a duplicate of w3c-fedid/custom-requests#2 . Feel free to reopen if you feel like there is something else here that isn't captured there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants