From e30732a69a068f0286356eef1e44504ce37218f7 Mon Sep 17 00:00:00 2001 From: Jake Archibald Date: Wed, 13 Mar 2019 15:45:30 +0000 Subject: [PATCH 1/4] Add cursor.request --- index.bs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/index.bs b/index.bs index e19ed4c..0d17baf 100644 --- a/index.bs +++ b/index.bs @@ -4617,6 +4617,7 @@ interface IDBCursor { readonly attribute IDBCursorDirection direction; readonly attribute any key; readonly attribute any primaryKey; + readonly attribute IDBRequest request; void advance([EnforceRange] unsigned long count); void continue(optional any key); @@ -4690,6 +4691,9 @@ object is modified, those modifications will be seen by anyone inspecting the value of the cursor. However modifying such an object does not modify the contents of the database. +The request attribute's getter must +return the [=cursor/request=] of this [=cursor=]. +
The following methods advance a [=cursor=]. Once the cursor has advanced, a `success` event will be fired at the From 8549b812ae6b38cad80e7ac41d241ec4dbc4f7cb Mon Sep 17 00:00:00 2001 From: Jake Archibald Date: Wed, 13 Mar 2019 17:28:13 +0000 Subject: [PATCH 2/4] Adding dev docs. Addressing nits. --- index.bs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/index.bs b/index.bs index 0d17baf..292bf28 100644 --- a/index.bs +++ b/index.bs @@ -4658,12 +4658,16 @@ enum IDBCursorDirection { Returns the [=cursor/effective key=] of the cursor. Throws a "{{InvalidStateError}}" {{DOMException}} if the cursor is advancing or is finished. +
cursor . {{IDBCursor/request}} +
+ Returns the [=cursor/request=] that was used to obtain this cursor. +
The source attribute's getter must -return the [=cursor/source=] of this [=cursor=]. This +return the [=cursor/source=] of the [=cursor=]. This attribute never returns null or throws an exception, even if the cursor is currently being iterated, has iterated past its end, or its [=/transaction=] is not [=transaction/active=]. @@ -4692,7 +4696,7 @@ inspecting the value of the cursor. However modifying such an object does not modify the contents of the database. The request attribute's getter must -return the [=cursor/request=] of this [=cursor=]. +return the [=cursor/request=] of the [=cursor=].
The following methods advance a [=cursor=]. Once the cursor has From 1d711c73c0ecfa578a984f9a5c8ded4077ed5912 Mon Sep 17 00:00:00 2001 From: Jake Archibald Date: Thu, 14 Mar 2019 07:48:01 +0000 Subject: [PATCH 3/4] Additional nits --- index.bs | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/index.bs b/index.bs index 292bf28..b697683 100644 --- a/index.bs +++ b/index.bs @@ -4698,6 +4698,12 @@ does not modify the contents of the database. The request attribute's getter must return the [=cursor/request=] of the [=cursor=]. + +
The following methods advance a [=cursor=]. Once the cursor has advanced, a `success` event will be fired at the @@ -7192,6 +7198,7 @@ For the revision history of the second edition, see [that document's Revision Hi * Updated [partial interface definition](#global-scope) since {{WindowOrWorkerGlobalScope}} is now a `mixin` ([PR #238](https://github.com/w3c/IndexedDB/pull/238)). * Added {{IDBFactory/databases()}} method. ([Issue #31](https://github.com/w3c/IndexedDB/issues/31)) * Added {{IDBTransaction/commit()}} method. ([Issue #234](https://github.com/w3c/IndexedDB/issues/234)) +* Added {{IDBCursor/request}} attribute. ([Issue #234](https://github.com/w3c/IndexedDB/issues/255)) # Acknowledgements # {#acknowledgements} @@ -7212,6 +7219,7 @@ for his general authoring advice. Special thanks to Chris Anderson, +Jake Archibald, Andreas Butler, Pablo Castro, Victor Costan, From 03636c15ad26ce232240702d7a221dd4cd480f5d Mon Sep 17 00:00:00 2001 From: Jake Archibald Date: Thu, 14 Mar 2019 17:03:14 +0000 Subject: [PATCH 4/4] Silly me --- index.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.bs b/index.bs index b697683..4f06902 100644 --- a/index.bs +++ b/index.bs @@ -7198,7 +7198,7 @@ For the revision history of the second edition, see [that document's Revision Hi * Updated [partial interface definition](#global-scope) since {{WindowOrWorkerGlobalScope}} is now a `mixin` ([PR #238](https://github.com/w3c/IndexedDB/pull/238)). * Added {{IDBFactory/databases()}} method. ([Issue #31](https://github.com/w3c/IndexedDB/issues/31)) * Added {{IDBTransaction/commit()}} method. ([Issue #234](https://github.com/w3c/IndexedDB/issues/234)) -* Added {{IDBCursor/request}} attribute. ([Issue #234](https://github.com/w3c/IndexedDB/issues/255)) +* Added {{IDBCursor/request}} attribute. ([Issue #255](https://github.com/w3c/IndexedDB/issues/255)) # Acknowledgements # {#acknowledgements}