-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should WindowClient.navigate(url) navigate with "replacement enabled"? #918
Comments
That does not seem correct indeed. For |
Does anyone vendor already implements it with replacement enabled? |
We're still working on it for gecko here: https://bugzilla.mozilla.org/show_bug.cgi?id=1218148 Looking at the current patches we are not using replacement. |
I agree: it makes more sense to not use replacement for |
Pre F2F notes: Absolutely seems like a copy-paste error on my part. |
F2F: Jake's an idiot and made a copy-paste error. This shouldn't be a replace. |
Currently the
navigate(url)
method is specified as navigating with replacement enabled. Is that correct? I wonder if that was just a mistaken copy of the text fromopenWindow
(where it probably is correct to navigate with replacement enabled).The text was updated successfully, but these errors were encountered: