Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should WindowClient.navigate(url) navigate with "replacement enabled"? #918

Closed
mkruisselbrink opened this issue Jun 23, 2016 · 6 comments
Closed
Labels
Milestone

Comments

@mkruisselbrink
Copy link
Collaborator

Currently the navigate(url) method is specified as navigating with replacement enabled. Is that correct? I wonder if that was just a mistaken copy of the text from openWindow (where it probably is correct to navigate with replacement enabled).

@mkruisselbrink mkruisselbrink added this to the Version 1 milestone Jun 23, 2016
@annevk
Copy link
Member

annevk commented Jun 24, 2016

That does not seem correct indeed. For openWindow() it is correct since you want to replace the initial about:blank.

@NekR
Copy link

NekR commented Jun 24, 2016

Does anyone vendor already implements it with replacement enabled?

@wanderview
Copy link
Member

We're still working on it for gecko here:

https://bugzilla.mozilla.org/show_bug.cgi?id=1218148

Looking at the current patches we are not using replacement.

@aliams
Copy link
Contributor

aliams commented Jul 25, 2016

I agree: it makes more sense to not use replacement for navigate().

@jakearchibald
Copy link
Contributor

Pre F2F notes: Absolutely seems like a copy-paste error on my part.

@jakearchibald
Copy link
Contributor

F2F: Jake's an idiot and made a copy-paste error. This shouldn't be a replace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants