Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disclosure FAQ: Should the answers be landmark regions? #1002

Closed
LaurenceRLewis opened this issue Mar 17, 2019 · 7 comments
Closed

Disclosure FAQ: Should the answers be landmark regions? #1002

LaurenceRLewis opened this issue Mar 17, 2019 · 7 comments
Labels
Example Page Related to a page containing an example implementation of a pattern Feedback Issue raised by or for collecting input from people outside APG task force question Issue asking a question

Comments

@LaurenceRLewis
Copy link

Due to the DL, DT DD structure being changed to a DIV structure I believe the example for disclosure widgets should also be updated. Happy to do this if approved.

Example Disclosure (Show/Hide) for Answers to Frequently Asked Questions
https://www.w3.org/TR/wai-aria-practices/examples/disclosure/disclosure-faq.html

Related to:

Accordion Example: Restructure to remove dl element #815#815

@jnurthen
Copy link
Member

DL, DD and DT seems like the right structure to me. The role is not being overridden in this example so can you explain the rationale to change it?

@LaurenceRLewis
Copy link
Author

@jnurthen just checking if it should be, as you point out the semantics are not being overridden, so in the old printing proof reading term STET :-) Leave it as it is.

@LaurenceRLewis
Copy link
Author

In relation to this

What is the difference between this Example Disclosure (Show/Hide)

Example on this page
https://www.w3.org/TR/wai-aria-practices/examples/disclosure/disclosure-faq.html#ex_label

and

Accordion Example
https://www.w3.org/TR/wai-aria-practices/examples/accordion/accordion.html

I don't quite get why one can have simple aria-expanded and aria-controls only while the accordion also includes role region and a different structure. Both essentially do the same thing.

I suggest a role of region is needed on the ‘disclosure (show/hide) as well for consistency.

@accdc
Copy link

accdc commented Mar 19, 2019

I'm in favor of adding role=region plus aria-labelledby to map back to the triggering element, especially to handle cases where show/hide controls like these are nested.

@charmarkk charmarkk added Example Page Related to a page containing an example implementation of a pattern Feedback Issue raised by or for collecting input from people outside APG task force question Issue asking a question labels Apr 16, 2019
@charmarkk charmarkk added this to the 1.1 APG Release 4 milestone Apr 16, 2019
@mcking65 mcking65 modified the milestones: 1.1 APG Release 4, 1.2 CR Aug 13, 2019
@mcking65 mcking65 changed the title DL DT DD structure in example Disclosure FAQ: Should the answers be landmark regions? Oct 17, 2021
@mcking65
Copy link
Contributor

Related to #954

@a11ydoer
Copy link
Contributor

a11ydoer commented Oct 29, 2021

@accdc please add/record your suggestion based on the discussion at APG meeting on Oct. 26. Thanks in advance.

@accdc
Copy link

accdc commented Nov 1, 2021

Hi,
In looking at the APG examples for disclosures, they look good to me and I don't think these need to be marked up as regions. Disclosures are a simpler concept than that of accordions, in that the interaction does not require multiple triggering elements in different locations, even if nested, so definitive grouping isn't really an issue. The option is still there if needed for complicated scenarios, but this is likely rare to occur.

@mcking65 mcking65 removed this from the 1.2 Release 1 milestone May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Example Page Related to a page containing an example implementation of a pattern Feedback Issue raised by or for collecting input from people outside APG task force question Issue asking a question
Development

No branches or pull requests

6 participants