Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error from github API gives blank error message in the UI #131

Open
wseltzer opened this issue Oct 11, 2018 · 2 comments
Open

Error from github API gives blank error message in the UI #131

wseltzer opened this issue Oct 11, 2018 · 2 comments
Labels
bug help wanted testing

Comments

@wseltzer
Copy link
Member

https://labs.w3.org/hatchery/repo-manager/pr/id/w3c/webauthn/1094 trying to mark non-substantive, I get a popup with an X but no text, and the change doesn't take.
@dontcallmedom dontcallmedom changed the title Can't mark as non-substantive, get blank message Error from github API gives blank error message in the UI Oct 16, 2018
@dontcallmedom
Copy link
Member

the bug that a PR couldn't be marked as substantive seemed to have been a now-over github API failure.

I'm keeping this bug open (and retitled) to improve the handling of these errors

@tripu tripu added the testing label Nov 13, 2018
@tripu
Copy link
Member

tripu commented Nov 13, 2018

Looks like an error generated server-side which isn't shown on the client; part of a general issue related to (lack of) client-side testing of the tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dontcallmedom @wseltzer @tripu