Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report operational errors #210

Open
dontcallmedom opened this issue Jul 15, 2021 · 2 comments · Fixed by #211
Open

Report operational errors #210

dontcallmedom opened this issue Jul 15, 2021 · 2 comments · Fixed by #211
Assignees

Comments

@dontcallmedom
Copy link
Member

There are at least two ways the checker can fail to process a pull request:

… and probably more. Right now, these failures are simply logged as a webook failure - useful for debugging, not for noticing there is a configuration issue.

These should instead be reported - either on the pull request itself, or on this repo (probably both - e.g. it could stay in "pending" state on the pull request status with an appropriate message, while reporting the issue here).

@deniak deniak self-assigned this Jul 15, 2021
@deniak
Copy link
Member

deniak commented Jul 15, 2021

I'll try to work on that in the next few days

@dontcallmedom
Copy link
Member Author

It would be useful to also report issues on webhooks with wrong secrets, a frequently occurring issue (although I've never quite figured how that happens)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants