-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove document.designMode #177
Comments
If you didn't have any metrics, the right solution is not to delete the feature. If you're making a proposal to remove this feature, please present an evidence that removing this feature is Web compatible. |
Oh, I found we've had it. [1] https://www.chromestatus.com/metrics/feature/timeline/popularity/1129 |
I am curious about the data. It only explained the first spike was due to switching to a more accurate system, but there is another spike around Mar 22, 2018 for both of them, I doubt that we suddenly get a higher usage for both features, so can we find out the reason behind? On the other hand, there is a browser behavior mismatch with For one example: <div>
foo
<div id=host></div>
</div> const host = document.getElementById('host');
const shadowRoot = host.attachShadow({mode:'open'});
shadowRoot.innerHTML = '<div>bar</div>'
document.designMode = 'on'; Content in shadow DOM (i.e. "bar" in this example) is editable in Firefox (note that shadow DOM support in Firefox is behind a flag From shadow DOM spec
It didn't mention shadow DOM should inherit If we are not deprecating |
@ctzsm An interesting observation. However, if noone uses designMode (except some cases to get around bugs in specific browsers), maybe time is better invested in other things than bringing designMode to Edge and fixing specific designMode behavior. We have actual issues that make are problematic for end users and editors, so let's try to resolve those first. Of course, if we determine that there is a reason to not only keep designMode for compatibility with old web pages but that there is also a reason to continue developing it, we should start standardizing it. But let's first make sure there is a usecase for it. So far noone has been able to find one. |
Edge DOES support designMode. What it doesn't currently support is shadow DOM API. I don't think we're comfortable removing this feature. |
This is just an idea from #176.
document.designMode = true
is same asdocument.documentElement.contenteditable = true
and it looks there is rarely any usecase today.Since I don't have any metrics so far, how about removing this feature for simpleness?
The text was updated successfully, but these errors were encountered: