Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that viewport meta allows decimal values #2557

Closed
mattgarrish opened this issue Apr 28, 2023 · 5 comments · Fixed by #2573
Closed

Clarify that viewport meta allows decimal values #2557

mattgarrish opened this issue Apr 28, 2023 · 5 comments · Fixed by #2573
Assignees
Labels
Change-Class-2 Requested changes are of class 2 (per process) Editorial For classifying errata only. Use Type-Editorial for issues EPUB33 Issues addressed in the EPUB 3.3 revision Errata Item accepted as an official errata for one or several specs Spec-EPUB3 The issue affects the core EPUB 3.3 Recommendation Spec-ReadingSystems The issue affects the EPUB Reading Systems 3.3 Recommendation Topic-FXL The issue affects fixed layout documents

Comments

@mattgarrish
Copy link
Member

As raised in w3c/epubcheck#1481, there are rare occurrences where the value of the viewport meta is expressed with a fractional part. The current definition, however, says the value must be a positive number, suggesting only positive integers are allowed.

We should probably make clear that decimal values are allowed but reading systems may ignore the fractional part.

@mattgarrish mattgarrish added Topic-FXL The issue affects fixed layout documents Spec-EPUB3 The issue affects the core EPUB 3.3 Recommendation Spec-ReadingSystems The issue affects the EPUB Reading Systems 3.3 Recommendation ErratumRaised Raise an erratum, not yet accepted by the maintainers. labels Apr 28, 2023
@iherman
Copy link
Member

iherman commented Jul 11, 2023

I would think that is a valid erratum and should be marked as such. Definitely a class 3 in my view.

@dauwhe @shiestyle @wareid @TzviyaSiegman

@iherman iherman added the Change-Class-3 Requested changes are of class 3 (per process) label Jul 18, 2023
@bduga
Copy link
Collaborator

bduga commented Jul 20, 2023

I am not sure there is a bug here. Decimal seems to imply the base, not that fractions are allowed (decimal vs hexadecimal, etc). "Number" is typically used to mean a whole number or one with a fractional part, "integer" typically means no fraction. For instance, see https://developer.mozilla.org/en-US/docs/Web/CSS/number, but it is pretty common for number to mean whole or fractional.

@mattgarrish
Copy link
Member Author

I don't think it's a bug as much as a minor clarification. Positive number was interpreted for epubcheck as whole numbers absent any other explanation of what we meant there.

I like the idea of just linking/citing the CSS number definition, though. That might also push this down to a class 2 change.

I'll update the pull request, at any rate, and if we decide not to do anything we can just close it off.

@iherman
Copy link
Member

iherman commented Jul 21, 2023

With the explicit reference to CSS as the only change, is this really a class-3 change? It smells class-2 change to me...

@mattgarrish
Copy link
Member Author

It smells class-2 change to me...

That's my take now, too. We're just making clearer the connection to the already referenced ICB immediately above the list items.

@iherman iherman added Change-Class-2 Requested changes are of class 2 (per process) and removed Change-Class-3 Requested changes are of class 3 (per process) labels Jul 21, 2023
@iherman iherman added Errata Item accepted as an official errata for one or several specs and removed ErratumRaised Raise an erratum, not yet accepted by the maintainers. labels Aug 4, 2023
@mattgarrish mattgarrish added Type-Editorial The issue does not affect conformance Editorial For classifying errata only. Use Type-Editorial for issues EPUB33 Issues addressed in the EPUB 3.3 revision and removed Editorial For classifying errata only. Use Type-Editorial for issues Type-Editorial The issue does not affect conformance labels Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Change-Class-2 Requested changes are of class 2 (per process) Editorial For classifying errata only. Use Type-Editorial for issues EPUB33 Issues addressed in the EPUB 3.3 revision Errata Item accepted as an official errata for one or several specs Spec-EPUB3 The issue affects the core EPUB 3.3 Recommendation Spec-ReadingSystems The issue affects the EPUB Reading Systems 3.3 Recommendation Topic-FXL The issue affects fixed layout documents
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants