Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What error should be returned when trying to access position from insecure origin? #12

Closed
yell0wd0g opened this issue Apr 12, 2017 · 4 comments
Labels
privacy-tracker Group bringing to attention of Privacy, or tracked by the Privacy Group but not needing response. question

Comments

@yell0wd0g
Copy link
Member

Chromium issue 702244 says Chromium returns a PERMISSION_DENIED, which sounds legit, but Safari might be returning a POSITION_UNAVAILABLE. I think Chromium response is OK and the alleged Safari response might be incorrect, but just in case it'd be great to clarify what's the expected error code when accessing from an insecure origin.

@yell0wd0g
Copy link
Member Author

+@jyasskin

@mkruisselbrink
Copy link
Contributor

FWIW the example in the Secure Contexts spec says to return PERMISSION_DENIED, but of course that's not normative.

@yell0wd0g
Copy link
Member Author

I think the WebKit line where the error is produced is https://github.com/WebKit/webkit/blob/master/Source/WebCore/Modules/geolocation/Geolocation.cpp#L366 :

    if (shouldBlockGeolocationRequests()) {
        notifier->setFatalError(PositionError::create(PositionError::POSITION_UNAVAILABLE, ASCIILiteral(originCannotRequestGeolocationErrorMessage)));
        return;
    }

@plehegar plehegar added question privacy-tracker Group bringing to attention of Privacy, or tracked by the Privacy Group but not needing response. labels Nov 20, 2017
@reillyeon
Copy link
Member

This was resolved by #34.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
privacy-tracker Group bringing to attention of Privacy, or tracked by the Privacy Group but not needing response. question
Projects
None yet
Development

No branches or pull requests

4 participants