Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sampling rate into Reporting? #71

Closed
dcreager opened this issue Jan 9, 2018 · 2 comments
Closed

Move sampling rate into Reporting? #71

dcreager opened this issue Jan 9, 2018 · 2 comments
Labels
v2 Will be considered for a later revision of this spec

Comments

@dcreager
Copy link
Member

dcreager commented Jan 9, 2018

On the WebPerf WG call last week someone asked whether it would make sense to move the sampling rate logic from the NEL spec into the Reporting spec, so that it would be more easily reusable across other specs. (This was brought up earlier on the Reporting side in reporting#45.)

The only wrinkle here is that NEL currently lets you set different sampling rates for successes and failures. If we move sampling rates into Reporting, we would need to either (a) make Reporting somehow allow multiple sampling rates per endpoint group (yuck), or (b) update NEL to let you choose different endpoint groups for successes and failures.

@dcreager dcreager added the v2 Will be considered for a later revision of this spec label May 22, 2018
@dcreager
Copy link
Member Author

dcreager commented May 22, 2018

Per w3c/reporting#45, we're leaving sampling rates in the dependent specs for now, and not moving anything into Reporting until we have >1 concrete examples to design from.

@clelland
Copy link
Contributor

Closing this now, as #124 and #133 are also both pulling in a separate direction, with configurable sampling rates based on different NEL error properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2 Will be considered for a later revision of this spec
Projects
None yet
Development

No branches or pull requests

2 participants