-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebDriver: Make it possible to pass a different origin to "Set Permission" #419
Comments
I guess we could do that w/ an optional POST body like |
I'm only familiar with the ChromeDriver code. At least there I don't think it'd be a big issue, as the code that fetches the current origin and passes it along is fairly simple. Gecko seems to have very limited support for this endpoint, but I dunno about WebKit. |
I had a chat with @jgraham in person at TPAC, and while he hasn't studied this issue in depth, he speculated that it shouldn't be too difficult for marionette/geckodriver if/when they implement the commands. |
Origin will be (hopefully) available in WebDriver BiDi command #436 |
Note: this has landed now. |
https://w3c.github.io/permissions/#set-permission-command changes permissions for "all environment settings objects whose origin is the same as the origin of [the current settings object]".
This is somewhat problematic from a testdriver perspective when cross-origin tests are involved: there are limitations that end up making all WebDriver communication go through the context that includes testharness.js, so if a given test includes a cross-origin iframe that needs to invoke "Set Permission" the call will go through the main frame and not have the desired effect.
Even though this is a testdriver limitation, I guess fixing it is not trivial, so I was wondering if the editors would be open to changing the spec itself to make it possible to (optionally) pass different origins.
The text was updated successfully, but these errors were encountered: