Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oldSubscription is never null #375

Open
annevk opened this issue Jul 8, 2024 · 0 comments
Open

oldSubscription is never null #375

annevk opened this issue Jul 8, 2024 · 0 comments

Comments

@annevk
Copy link
Member

annevk commented Jul 8, 2024

Presumably oldSubscription is null the first time you create a push subscription, but this isn't actually stated anywhere. Instead there's an assumption there's always a push subscription holding the old keys presumably resulting in a crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant