Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple mechanism to share code between browser-specs and Reffy? #1589

Open
tidoust opened this issue Jun 7, 2024 · 0 comments
Open

Simple mechanism to share code between browser-specs and Reffy? #1589

tidoust opened this issue Jun 7, 2024 · 0 comments

Comments

@tidoust
Copy link
Member

tidoust commented Jun 7, 2024

There's a bit of duplicated logic between browser-specs and Reffy:

  • the method that loads a spec with Puppeteer (although there are a few nuances on that one)
  • the throttled queue, which could end up being useful in other projects as well.

It would be good if we could share the code instead of duplicating it. Creating an NPM package is a bit overkill and would create maintenance overhead. We could perhaps import the code directly though, e.g. by switching to ESM modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant