Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on animation frame task #136

Closed
Johanna-hub opened this issue Jan 22, 2019 · 4 comments
Closed

Clarification on animation frame task #136

Johanna-hub opened this issue Jan 22, 2019 · 4 comments

Comments

@Johanna-hub
Copy link
Contributor

Currently in the spec we have:

The following is used but not defined in [[FULLSCREEN]]: animation frame task.

According to the fullscreen issue referenced above the timing is now defined and the issue has been closed.

@foolip Would you please be able to clarify what this means for the definition in the Screen Orientation spec and also where animation frame task appears in the algorithms:

If locking the orientation did not result in a change of orientation, as part of the next animation frame task, resolve pending-promise with undefined and set pending-promise to null.

Whenever the viewport's angle changes, the user agent MUST run the following steps as part of the next animation frame task:

Whenever a document becomes visible per [[!PAGE-VISIBILITY]], in other words after the now visible algorithm is run, the user agent MUST run the following substeps as part of the next animation frame task:

Thank you very much for your help 🙂

@marcoscaceres

This comment was marked as resolved.

@foolip
Copy link
Member

foolip commented Jan 24, 2019

The way to integrate with the event loop that we ultimately landed on is https://fullscreen.spec.whatwg.org/#run-the-fullscreen-steps. There is a step in https://html.spec.whatwg.org/multipage/webappapis.html#update-the-rendering that calls out to HTML.

This does mean that HTML needs to know about all the specs that integrate with it, which is arguably backwards layering-wise, but the upside is that the order of things is clearly defined, and cannot really be well defined without a central point of order.

@Johanna-hub
Copy link
Contributor Author

@foolip Thanks so much

@marcoscaceres
Copy link
Member

Closing as duplicate of #219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants