-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should this prompt? #324
Comments
This plan sounds OK to me at least.
Hmm, given the discussions in w3c/permissions#247 and that Chromium does implement this integration with the Permissions API, is there a specific reason for changing course here? |
My concern is that we have a permission that’s not tied to a permission UI, so it doesn’t fit the purpose of the Permission spec. So, |
In w3c/permissions#247 @martinthomson agreed that there's no substantial harm if |
After gaining some more implementation experience and delving a little deeper into this topic, I have to disagree with @martinthomson on this one - as:
I'd prefer we "unhook" screen wake lock from the Permission spec for now, until such time that we are 100% sure that there will be an actual permission UI. So, I'm not saying we shouldn't have this eventually - I'm saying it's premature right now to have Permission API integration right now. |
I find that argument convincing. If no UA is going to implement this as a permission, then that makes sense. If we can standardize behaviour that has no permissions, that is best for all involved. If we have to add permissions in the future, I don't think that would prevent us from doing so. I am merely willing to accept that Chrome might want to manage this as a permission. One thing to add though: Are we not considering using Permissions Policy to control this? That is, might sites want to prevent nested browsing contexts accessing the feature? That might suggest that there is still some value in the integration. |
Yes, it's a policy controlled feature. But even in that case, the Permissions Policy's API is the appropriate way to query this: document.permissionsPolicy.allowsFeature("screen-wake-lock"); For policy controlled features, |
Ping on this one also. Be nice if the Editors would address this bug as it's been over a year now. |
@rakuco, please update the specification to remove the integration with the Permissions API since no implementation supports denying permission to use this feature. |
Screen Wake Lock lands in Firefox 124 without a permission prompt. But we are thinking about having a setting so that a user can disable the API, see Bug 1877413. We haven't reached consensus yet but are interested in relying on the permissions API integration with Screen Wake Lock to implement these settings. |
Thank you for sharing your implementation experience here. While I'm not particularly proud of the inaction here it seems like there is some desire for this option in the API. |
As discussed at TPAC 2024:
|
Current implementations haven't found a need to show a permission prompt for screen wake lock (or give a way for a user to "deny" the permission).
In particular, I wonder if we should remove:
That's just a "statement of fact".
My suggestion is that we keep the "screen-wake-lock" permission (which is used with Permission Policy - i.e., the HTTP header and
allow=
), but we then drop "screen-wake-lock" from the Permission spec itself.We can always add it back later?
@reillyeon @kenchris @rakuco @anssiko - interested in your thoughts on this.
The text was updated successfully, but these errors were encountered: