Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more visibility tests #373

Open
marcoscaceres opened this issue Apr 9, 2024 · 1 comment
Open

Add more visibility tests #373

marcoscaceres opened this issue Apr 9, 2024 · 1 comment

Comments

@marcoscaceres
Copy link
Member

elsewhere @rakuco suggested adding a test:

using window_state_context() to change the page visibility after calling request() and verifying the latter fails

As a reminder to myself (or whomever creates that), we should do that in separate file....

@rakuco
Copy link
Member

rakuco commented Apr 9, 2024

For future reference: we already have screen-wake-lock/wakelock-document-hidden.https.html that tests that calling request() after setting the page visibility state to "hidden" throws NotAllowedError. What I was wondering is whether we could test the specific case being added in #367 (i.e. the page is visible when request() is called, so the visibility check passes, but the visibility changes to "hidden" before the "fully active" check in the parallel steps happens).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants