-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendor information in the response from traced service #466
Comments
Thanks for the feedback and the above comment. We are looking to understand better the use cases you describe above: will you be able to share a use case of what a caller might do with the above information? |
Hi, @kalyanaj Let me elaborate on the use-cases a bit:
|
Seems like this use case would be addressed if you simply send |
How would sending The qestion is, do the described use cases warrant adding something like this as a new specification feature. I am tentatively leaning toward a "no". The first use case in particular does not involve a scenario that needs to work across vendors, but is always vendor specific by nature (assuming I am understanding it correctly). |
I tend to agree with that. The overall use case has a tight coupling in functionality between the client and the server. Nothing is blocking this use case today, and the benefits of standardization are not very unclear, because all the benefits listed by the OP can only materialize iff there is the same vendor on both sides of the call. |
Have you considered providing vendor information in a response from traced service in addition to
traceresponse
header (which provides information, that the call was traced, but without vendor information)?This can be achieved by vendors adding proprietary headers, in addition to the
traceresponse
header.However, having it standardized has a few benefits - the main being, having a standard way of detecting what kind of agent/vendor is generating trace events.
I believe this might be standardized similarly, to how this is done with the
tracestate
header for the traced Request.Use-cases:
Rough proposal:
traceresponsestate
header, with a format similar totracestate
header. However, the value might only relate to the last call (it doesn't need to be passed all the way back from the last service to the first caller) - simplification compared totracestate
which is preserved for every down-stream call - up for a discussionThe text was updated successfully, but these errors were encountered: