Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule.json file does not always get updated correctly #251

Open
WilcoFiers opened this issue Nov 2, 2023 · 2 comments
Open

rule.json file does not always get updated correctly #251

WilcoFiers opened this issue Nov 2, 2023 · 2 comments

Comments

@WilcoFiers
Copy link
Collaborator

I spotted that after an update to the letter spacing rules recently two of the three were switched to deprecated for no apparent reason, and their rule name wasn't changed correctly. I switched it back manually, which works for now, but I'd like to know why this happened so we can prevent it in the future.

d2b0901

@WilcoFiers
Copy link
Collaborator Author

Turns out there is also a problem with testcases.json. Several test cases are now missing from the word spacing rule. This probably happened because this PR duplicated two of the spacing rules, deprecating the older version of it. That doesn't work because the IDs were kept the same: https://github.com/act-rules/act-rules.github.io/pull/1923/files

I'm discussing with @Jym77 and @carlosapaduarte whether we need to change the rule IDs or if we need to delete the deprecated rule files.

@Jym77
Copy link
Collaborator

Jym77 commented Nov 6, 2023

Should be fixed by act-rules/act-rules.github.io#2134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants