Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source IDL for idlharness.js tests should be auto-synced from latest draft specs #7784

Closed
mdittmer opened this issue Oct 16, 2017 · 6 comments

Comments

@mdittmer
Copy link
Contributor

This should be relatively straightforward, given that https://github.com/GoogleChrome/webidl-diff already contains code for locating specs, extracting IDL, and verifying it (by parsing it).

@foolip
Copy link
Member

foolip commented Jan 24, 2018

This came up in bit.ly/ecosystem-infra-rotation today. This work is planned for this quarter so the priority label is actually correct, see details in Changes to Web IDL in specs automatically propagate to wpt PRs.

aarongable pushed a commit to chromium/chromium that referenced this issue Mar 7, 2018
So that https://github.com/GoogleChromeLabs/webidl-diff finds the
shorter links and processes those. Part of
web-platform-tests/wpt#7784.

Change-Id: I9697f7f1ae0e1960031ca25979295c8b8282f441
Reviewed-on: https://chromium-review.googlesource.com/952668
Commit-Queue: Miguel Casas <[email protected]>
Reviewed-by: Miguel Casas <[email protected]>
Cr-Commit-Position: refs/heads/master@{#541475}
aarongable pushed a commit to chromium/chromium that referenced this issue Mar 7, 2018
These all redirect. Process was to copy into browser, follow redirect
and copy URL back. In a few cases where the anchor wasn't there, I found
the correct URL instead.

Really in order to get the URLs in *.idl correct, related to
web-platform-tests/wpt#7784.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iab73c1d51b1da4ab66c0e8314b0b3e701bbd19f2
Reviewed-on: https://chromium-review.googlesource.com/952298
Reviewed-by: Fredrik Söderquist <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: Philip Jägenstedt <[email protected]>
Cr-Commit-Position: refs/heads/master@{#541595}
aarongable pushed a commit to chromium/chromium that referenced this issue Mar 10, 2018
Part of web-platform-tests/wpt#7784 and
roundabout manner.

Change-Id: I7a11d22240784d94776d77ca07d0c28b1ef12736
Reviewed-on: https://chromium-review.googlesource.com/952670
Reviewed-by: Emily Stark <[email protected]>
Commit-Queue: Philip Jägenstedt <[email protected]>
Cr-Commit-Position: refs/heads/master@{#542295}
@mdittmer
Copy link
Contributor Author

@dontcallmedom talked about getting reffy to output these IDL snippets, because its analysis needs to parse and interpret the IDL anyway. Dominique, when do you think publishing the IDL snippets could be integrated into report generation?

@foolip foolip assigned lukebjerring and unassigned mdittmer Jun 4, 2018
@foolip
Copy link
Member

foolip commented Aug 4, 2018

This is in progress, see the linked project.

@foolip
Copy link
Member

foolip commented Aug 8, 2018

I have something in progress in https://github.com/foolip/wpt-idl-importer.

@foolip
Copy link
Member

foolip commented Aug 16, 2018

Suggesting in w3c/webref#20 to trigger the updates from reffy-reports directly instead.

@lukebjerring lukebjerring assigned foolip and unassigned lukebjerring Aug 28, 2018
@foolip
Copy link
Member

foolip commented Sep 11, 2018

This is now done, PRs will be automatically created to reflect any changes that happen in reffy-reports.

@foolip foolip closed this as completed Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants