No longer allow Chrome stability check to fail #10082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build PASSEDStarted: 2018-03-16 21:22:08 View more information about this build on: |
|
Labelling this so I don't accidentally approve/merge it. :) |
foolip
approved these changes
Mar 20, 2018
|
Just examined the recent builds. I feel confident enough to flip the switch now. @gsnedders @jgraham FYI I'm landing this. In the unlikely event that you see an unreasonable amount of false alarms caused by the Chrome stability job, feel free to revert this any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #10064, Chrome jobs run successfully on Travis, so we can turn the
stability check back on.
Fixes #9932.
Note: I'm not planning to land this immediately. Just sending this out now, and I'll wait for some more Travis builds and see how they go next week.
This change is