-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
negotiationneeded
event payload should be more descriptive about what is triggering the event
#3003
Comments
Skeptical. Apart from debugging, this would seem to have little utility. |
Apart from debugging, the main utility would be that depending on the "negotiation cost" in given scenarios, a developer could safely opt not to renegotiate. Is there another way to evaluate what triggers the event? |
There are two views of the world:
There is not much middle ground left for "kinda interested in ONN but wants to know more". chrome's webrtc-internals page has "transceiverAdded" and similar events but those turned out to be more confusing than helpful. |
The problem with this view is that only some developers control both sides of the communication. |
Summary
The
negotiationneeded
event currently lacks detailed information about what specifically triggers it. This limitation makes it challenging for developers to handle signaling efficiently, especially in complex applications where multiple actions can cause renegotiation.Detailed Description:
When the negotiationneeded event is fired on an RTCPeerConnection, it does not provide any context about the underlying reason. For instance, the event could be triggered by:
Adding a new track via addTrack() or addTransceiver()
Removing a track with removeTrack()
Changing the parameters of an RTCRtpSender
Modifications to data channels
Other internal state changes that require renegotiation
Without knowing the specific cause, developers might:
Perform unnecessary or redundant signaling operations
Face difficulties in optimizing the negotiation process
Encounter challenges in debugging and maintaining code
Proposed Solution:
Enhance the
negotiationneeded
event by including additional information in its payload that describes the reason(s) for the event. This could be achieved by:Example
Benefits:
The text was updated successfully, but these errors were encountered: