Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine example Thing Description #389

Open
Tracked by #375
mlagally opened this issue Apr 17, 2023 · 0 comments
Open
Tracked by #375

Refine example Thing Description #389

mlagally opened this issue Apr 17, 2023 · 0 comments

Comments

@mlagally
Copy link
Contributor

mlagally commented Apr 17, 2023

@benfrancis commented:

I think this example could use work. I'm not sure why the fireAlarm event would be fired when the button has been re-armed, and I'm not sure how a Consumer would know anything about sprinkler status. The cancellation payload format and unsubscribe protocol binding need updating to match the protocol binding in the specification text, i.e. DELETE instead of POST and provide the subscription ID in the URL rather than the body (a DELETE request does not usually contain a body).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants