-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL Protocol Handler Registration for PWAs #482
Comments
@samtan-msft thanks for sending this. Do you have an idea where this might go after incubation in WICG? |
@torgo we initially thought about having it incubated in WICG, but as discussed on this thread the spec side of this work might be rather small and it has been suggested it could be treated as a spec bug and discussed as an issue on the manifest repo. What do you think? @marcoscaceres how does that sound to you? We already have w3c/manifest#846, and we could just iterate there? |
Hey, quick question, is anyone looking at this on the TAG side at this moment? |
Sorry I missed this earlier. That seems fine... however, it doesn't hurt to get TAG feedback :) |
We are re-evaluating based on the new info in w3c/manifest#846... @marcoscaceres do you have any additional thoughts on this you could share in the context of this review? One thing we're concerned about is the possibility for things to get "out of sync." |
Hi @fabiorocha @Maggers @connor-moody @samtan-msft! @kenchris and I looked at this during a breakout of this week's TAG F2F. Overall we like the idea of adding this functionality to Web App Manifest, but we share the concerns our colleague @dbaron raised in mozilla/standards-positions#340 (comment). We'd like to see this new manifest feature and the existing |
Hi @fabiorocha @Maggers @connor-moody @samtan-msft, Any thoughts on the above? |
@hober My sincere apologies for letting this fall through the cracks. Thanks for the ping! I think that makes a lot of sense, conceptually. Would you have pointers to the Fetch changes you mentioned as an example for this? Do you think both changes need to be staged at the same time or can one come before the other? I'd appreciate further guidance here. |
The addition of the Fetch spec itself is the change I was referring to. Before Fetch, we had XHR. When Fetch got specced, a common model was defined that both XHR and the Fetch API could be defined on top of.
I think it would be best if they were both staged at the same time; that way, each can link to the other so people understand why the changes are happening. If one came before the other, it should probably be the HTML change that happens first. |
Hi @fabiorocha - @kenchris and I are just coming back to this issue in our "f2f" today and we're wondering if there has been any update? Can you let us know the current status? Is this something we should close for now? |
Hola TAG, We are looking into this. We opted for not changing the HTML5 spec and are rather thinking of making the Manifest spec dependent on the HTML one by referencing parts of it. We are working on the PR and will update with more info on this very soon. gracias |
Hey, HTML spec editor here. I don't think it's appropriate to change how navigation works without changing the HTML spec... See also w3ctag/design-principles#184 and https://annevankesteren.nl/2014/02/monkey-patch . |
@domenic I don’t believe we are monkey patching. Our current plan—which @diekus is referring to—is to reference the HTML spec’s logic for normalizing/vetting protocol handlers, which is analogous to how Assuming HTML doesn’t abandon the Protocol Handler API, we don’t foresee it becoming an issue. And if it comes to pass that As I understand it, the plumbing of the two approaches will be largely the same as this is, essentially, a declarative means of doing what |
Hmm, maybe I misunderstood this then. Sure, definitely reference HTML's logic for normalizing/vetting protocol handlers. But what spec will be modified to actually say that when a manifest registers for
Indeed, navigation is defined in HTML. However this is orthogonal to registerProtocolHandler. Any navigations that are intercepted, regardless of whether they're intercepted because of registerProtocolHandler or because of some manifest entry, are handled by HTML. |
@domenic Thinking about verbiage, how would you frame the state of being installed? Is that considered/mentioned elsewhere in the HTML spec? |
So far I am not aware of any web platform features which work differently in installed contexts vs. not. (That might be a good architectural issue for the TAG to consider for this review!) If you did want to proceed down that path, introducing such a definition (either in the manifest spec or the HTML spec) which HTML could reference would make sense. |
Let's hope we don't start getting that kind of divergence. That would not be great.
Agree. Though I'm hopeful that apart from very subtle/transparent things (e.g., maybe an increased storage quota, or slightly longer cookie persistence), nothing will differentiate installed from regular web apps. |
@diekus maybe you want to add your self to primary contacts and give us an update on the status of this Btw this was published yesterday: https://web.dev/url-protocol-handler/ |
@kenchris Hola Kenny ! How do I add myself as "primary contact"? I am the PM for this feature so indeed I am your preferred point of contact. (Sorry my first time helping with a TAG review). Thanks for the heads up about the web.dev article, our team at MS collaborated with this indeed! To give you an update about this, we have submitted 2 changes to the HTML spec to add 2 new definitions to it to align the manifest spec with the processes in the registration and invocation of protocol handlers in the HTML one. You can see the PRs here and here. They have both been merged and I have unblocked this to continue work on the manifest spec. |
@diekus I added you now |
@diekus thank you for the quick reply and detailed update. Looking how far this has matured it looks like we should be able to sign off unless there is anything else in your mind that we need to go over? |
@atanassov All is good on our side and I'm happy to sign off. Just out of curiosity, in the TAG review process, what does this sign off mean? is it like an A+ on your grades? |
We (@torgo, me and @atanassov) looked at this in our breakout today and we are happy with the progress and the collaboration with WHATWG on getting this aligned with existing specs and getting the changes incorporated into HTML. Going to close this! Thanks for bringing this to the TAG! |
Hello TAG!
I'm requesting a TAG review of URL Protocol Handler Registration for PWAs
This feature will allow web developers to register web applications as URL protocol handlers via a property in the web app manifest. The apps would open directly when a custom-scheme URL is visited. Implementation-wise, we intend to build this feature by reusing registerProtocolHandler internally and modifying the protocol handler registry and shell integration classes to account for the existence of PWAs. The idea is to avoid code duplication and maintain the APIs aligned. (see explainer and design doc for more details)
Further details:
w3c/manifest#846
blink-dev
WICG discourse thread
We'd prefer the TAG provide feedback as:
💬 leave review feedback as a comment in this issue and @-notify @fabiorocha @Maggers @connor-moody @samtan-msft
The text was updated successfully, but these errors were encountered: