You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Whether this eats up a lot of performance or not very much depends on 1) how many calls we're making, and 2) which exact version of Linux the user's running (IIRC there were some performance optimizations done to getrandom).
Nevertheless, this is a good idea.
My runtime SIMD detection PR was recently merged in curve25519-dalek, so as soon as there's a new release I'll be making a PR switching to the new version and releasing a new schnorrkel. I can also take care of this issue then if you want. (Unless you want to do it yourself earlier.)
We've no reason for a separate rand feature I think. If getrandom works then ThreadRng works. As an aside, getrandom's custom feature should simplify life for possible cargo patch users (hardware wallets?), so afaik that's not a concern either.
Revert c333370 and fix rand. We've way less churn in rand today, and this syscall surely hurt performance ala paritytech/polkadot-sdk#732
The text was updated successfully, but these errors were encountered: