Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid having to write on disk the image #106

Closed
ChrisCinelli opened this issue Nov 29, 2018 · 2 comments
Closed

Avoid having to write on disk the image #106

ChrisCinelli opened this issue Nov 29, 2018 · 2 comments

Comments

@ChrisCinelli
Copy link
Contributor

I worked on fixing this during another PR but it looks like that, even eliminating concurrency, the tar.Reader does not behave as I wanted and ended up cutting some bytes.
On the other side when it was working, the initialization was super fast.

@ChrisCinelli
Copy link
Contributor Author

I was actually able to make it work. The code is on https://github.com/ChrisCinelli/dive/tree/feature/cc/do-not-write-image
Concurrency is off but dive loads a lot faster compare to the usual time on my machine and memory consumption is always around 16Mb =)

@wagoodman
Copy link
Owner

Fixed by #108 , thanks for digging in on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants