Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Light client interop tests #608

Closed
1 task
chaitanyaprem opened this issue Jul 15, 2023 · 8 comments
Closed
1 task

Add Light client interop tests #608

chaitanyaprem opened this issue Jul 15, 2023 · 8 comments
Labels
E:End-to-end testing See https://github.com/waku-org/pm/issues/34 for details epic Tracks a yearly team epic (only for waku-org/pm repo)

Comments

@chaitanyaprem
Copy link
Collaborator

chaitanyaprem commented Jul 15, 2023

Planned start date:
Due date:

Summary

All interop tests for Light client with nwaku or go-waku service nodes.

Acceptance Criteria

  • Interop tests with nwaku should be sucessful for light client protocols.

Tasks

RAID (Risks, Assumptions, Issues and Dependencies)

@chaitanyaprem chaitanyaprem self-assigned this Jul 15, 2023
@chaitanyaprem chaitanyaprem changed the title chore: Add Light client tests Add Light client interop tests Jul 31, 2023
@fryorcraken
Copy link
Collaborator

@chaitanyaprem I am not too familiar with the context of this issue, are you happy to update the description as per waku-org/pm#40 ?

@fryorcraken fryorcraken added milestone Tracks a subteam milestone E:2023-light-protocols labels Aug 3, 2023
@chaitanyaprem chaitanyaprem changed the title Add Light client interop tests [Milestone] Add Light client interop tests Aug 7, 2023
@chaitanyaprem chaitanyaprem removed their assignment Aug 7, 2023
@fryorcraken

This comment was marked as resolved.

@chaitanyaprem
Copy link
Collaborator Author

Ok, the reason i was thinking this may be required is that there seems to be a light node option in status-desktop @richard-ramos was showing in one of the calls. If that is possible, then go-waku <-> nwaku and go-waku(light client) <-> go-waku interop tests would be required right.
Anyways better to confirm this with status-desktop team and if it is not required, we can move it out of 2023 scope.

@fryorcraken
Copy link
Collaborator

fryorcraken commented Aug 9, 2023

Oh really sorry, I misread the issue. Yes totally agree it's in scope.

@fryorcraken fryorcraken changed the title [Milestone] Add Light client interop tests [Epic] Add Light client interop tests Aug 24, 2023
@fryorcraken fryorcraken added epic Tracks a yearly team epic (only for waku-org/pm repo) and removed milestone Tracks a subteam milestone labels Aug 24, 2023
@fryorcraken
Copy link
Collaborator

I would focus on go-waku(client)<>go-waku(server) tests. Is something not currently available?

For tests involving js-waku and nwaku. This would be part of the work done by @fbarbu15

@chaitanyaprem
Copy link
Collaborator Author

chaitanyaprem commented Aug 30, 2023

I would focus on go-waku(client)<>go-waku(server) tests. Is something not currently available?

Ok, As of now I don't think we have any tests for this.
I think we are dependent on Status for these tests. @richard-ramos , correct me if i am wrong.
Shouldn't they be go-waku(client) <-> nwaku interop? I wasn't aware of go-waku is being considered to be run as service-node as being priority.

@chaitanyaprem chaitanyaprem changed the title [Epic] Add Light client interop tests Add Light client interop tests Sep 5, 2023
@fryorcraken
Copy link
Collaborator

Actually this is part of the DST work done by @fbarbu15
I created an Epic to track: waku-org/pm#34

@fryorcraken fryorcraken added the E:End-to-end testing See https://github.com/waku-org/pm/issues/34 for details label Sep 12, 2023
@chaitanyaprem
Copy link
Collaborator Author

Closing this based on above comment as it is being tracked by DST work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:End-to-end testing See https://github.com/waku-org/pm/issues/34 for details epic Tracks a yearly team epic (only for waku-org/pm repo)
Projects
Archived in project
Development

No branches or pull requests

2 participants