feat: allow passing of multiple ENR URLs to DNS Discovery & dial multiple peers in parallel #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
size-limit report 📦
|
weboko
reviewed
Jun 1, 2023
packages/dns-discovery/src/index.ts
Outdated
| @@ -32,7 +32,7 @@ export interface Options { | |||
| /** | |||
| * ENR URL to use for DNS discovery | |||
| */ | |||
| enrUrl: string; | |||
| enrUrls: string[]; | |||
There was a problem hiding this comment.
Maybe we can do string | string[]?
fryorcraken
approved these changes
Jun 2, 2023
There was a problem hiding this comment.
I agree with @weboko to make API still accept string as well as string[]
|
instead of enable I'd use allow inPR title (for changelog) Also, if you do |
danisharora099
changed the title
fryorcraken
force-pushed
the
feat/several-enrtree-multiaddr
branch
from
1153394
to
b71930c
Compare
* ensure discovered peers are dialed in parallel * cap parallel dials * drop connection to bootstrap peer if >set connected * switch to american english * improve promises and error logging
weboko
changed the title
Merged
Closed
This was referenced Sep 11, 2023
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses point 1 at #1326