Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create abstraction over ENR-related access between PeerStore #1648

Open
danisharora099 opened this issue Oct 10, 2023 · 0 comments
Open

create abstraction over ENR-related access between PeerStore #1648

danisharora099 opened this issue Oct 10, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@danisharora099
Copy link
Collaborator

This is a feature request

Problem

With #1626, discovery classes currently write details from the ENR into the PeerStore converting into bytes, and then decode this information when we want to use it elsewhere (eg ConnectionManager)

Also, with work on #1463, it may be required to store more information from the ENR into the PeerStore.

The process of manually encoding and decoding between access to the PeerStore is somewhat redundant and can be improved.

Proposed Solutions

Create abstraction over the PeerStore.save() method to save parts of the ENR and access from the PeerStore.

eg: saveToPeerStore({x, y, z})

Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To Do
Development

No branches or pull requests

1 participant