bug: ApplicationInfo to PubsubTopic doesn't take clusterId into consideration

[fbarbu15]

This is a bug report

Problem

shardInfoToPubsubTopics and ensureShardingConfigured doesn't take clusterId into consideration when resolving the PubsubTopic for ApplicationInfo

IMO this needs to work because ApplicationInfo also contains clusterId and I expect the PubsubTopic to match it

Proposed Solutions

clusterId needs to be passed to contentTopicToPubsubTopic in those 2 functions

[danisharora099]

related to waku-org/nwaku#2502

[fbarbu15]

This was fixed on nwanku side here

[danisharora099]

@fbarbu15 I'm not sure I fully understand this issue. clusterId is indeed taken into account with ApplicationInfo.
What am I missing?

js-waku/packages/utils/src/common/sharding.ts

Lines 63 to 70 in 4db508b

	} else if ("application" in shardInfo && "version" in shardInfo) {
	// Autosharding: single shard from application and version
	return [
	contentTopicToPubsubTopic(
	`/${shardInfo.application}/${shardInfo.version}/default/default`,
	shardInfo.clusterId
	)
	];

cc @waku-org/js-waku-developers

[fbarbu15]

Sorry, totally forgot about this issue
I've applied this fix when I worked on js-waku sharding tests
If it's not correct please feel free to revert/fix it

[fbarbu15]

Closing according to the above comment