Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: create scripts for running light-push/filter and measuring ratio of messages sent and received #2007

Open
Tracked by #2154
adklempner opened this issue May 9, 2024 · 4 comments
Assignees
Labels
E:js-waku Reliability Protocol for Resource-Restri test Issue related to the test suite with no expected consequence to production code

Comments

@adklempner
Copy link
Member

This is a bug report/feature request/support request/change request

Problem

Current efforts of testing long-term usage of js-waku required manually running an example and observing it. We should move towards a more automated solution.

Proposed Solutions

  1. Script that once loaded in an html page (or headless browser) begins sending monotonically increasing messages over light push. It should clearly display/report which messages failed to send
    a. parametrize period between messages
    b. parameterize whether to use default bootstrapping or specific nodes/fleets
    c. parameterize content topic/shard info
  2. Script that once loaded in an html page (or headless browser) listens to message sent from 1. It should clearly display/report which message were missed.

Notes

  • Refer to browser testing package
@adklempner adklempner self-assigned this May 9, 2024
@adklempner adklempner added enhancement New feature or request test Issue related to the test suite with no expected consequence to production code labels May 9, 2024
@chair28980 chair28980 added E:js-waku Improve Reliability and removed enhancement New feature or request labels May 20, 2024
@fryorcraken
Copy link
Collaborator

Sounds good. I am guessing we should aim to use different nodes for filter and light push?
Caveat is if the node is offline, then it may not be straight forward to detect, I guess that light push would fail which will help detect it?
We need to be sure we cater for scenarios with total loss of connections and understand how we measure those effectively.

@adklempner
Copy link
Member Author

The scope of this work has changed since I started and discussed more with others, I've captured it here: waku-org/lab.waku.org#69

@weboko
Copy link
Collaborator

weboko commented Sep 17, 2024

Our strategy is to:

This is absolutely necessary and assumption is that it is part of any change we do now.

cc @waku-org/js-waku @waku-org/js-waku-developers

@weboko
Copy link
Collaborator

weboko commented Sep 17, 2024

As for making it part of automated CI we have to investigate how it can be incorporated into PR gates as there is a risk of making it too flaky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:js-waku Reliability Protocol for Resource-Restri test Issue related to the test suite with no expected consequence to production code
Projects
Status: To Do
Development

No branches or pull requests

4 participants