Skip to content

Commit

Permalink
fix: libwaku.nim: unsubscribe -> unsubscribeAll to make it build prop…
Browse files Browse the repository at this point in the history
…erly (#2082)

* libwaku.nim: unsubscribe -> unsubscribeAll to make it build properly

We introduced a change in the next PR
#1983
that made the `libwaku` to stop building properly
(make libwaku) because a signature change in the
`unsubscribe` proc of waku/waku_relay/protocol.nim.

This commit is a temporary workaround to make it work,
and not block any ongoing PR tests,
although not exactly as it is expected because we are
unsubscribing from all topics.

* ci.yml: adds library/** to force tests when changes under that folder
  • Loading branch information
Ivansete-status authored Sep 26, 2023
1 parent 6cb9a8d commit 3264a4f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ jobs:
- 'vendor/**'
- 'Makefile'
- 'waku.nimble'
- 'library/**'
v2:
- 'waku/**'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@ proc process*(self: ptr RelayRequest,
node.wakuRelay.subscribe($self.pubsubTopic, self.relayEventCallback)

of UNSUBSCRIBE:
node.wakuRelay.unsubscribe($self.pubsubTopic)
# TODO: properly perform 'unsubscribe'
node.wakuRelay.unsubscribeAll($self.pubsubTopic)

of PUBLISH:
let numPeers = await node.wakuRelay.publish($self.pubsubTopic,
Expand Down

0 comments on commit 3264a4f

Please sign in to comment.