Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow providing node key using a file #1593

Open
jakubgs opened this issue Mar 6, 2023 · 2 comments
Open

feat: allow providing node key using a file #1593

jakubgs opened this issue Mar 6, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers infra Infra, devops, CI and related tasks

Comments

@jakubgs
Copy link
Contributor

jakubgs commented Mar 6, 2023

Problem

Currently the only way to pass nod key to the node is using --nodekey flag which only accepts a string.

This is not optimal as it means you have to for example embed the node key in service definition which might have wider permissions that it warrants considering the sensitive nature of the key.

Suggested solution

A separate flag - or path support for the current flag - would resolve this.

@jakubgs jakubgs added enhancement New feature or request infra Infra, devops, CI and related tasks track:production labels Mar 6, 2023
@mfw78
Copy link

mfw78 commented Mar 7, 2023

FYI, one can actually pass the node key via an environment variable, notably WAKUNODE2_NODEKEY.

@jakubgs
Copy link
Contributor Author

jakubgs commented Mar 7, 2023

Yes, I'm already doing exactly that: NixOS/nixpkgs#193679 (comment)

But the issue with that is that if you for example mistype the key name it will fail silently and use a random key.
If you have an explicit key flag file and the file doesn't exist, or is empty, or has bad format, it will fail explicitly.

@vpavlin vpavlin added the good first issue Good for newcomers label Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers infra Infra, devops, CI and related tasks
Projects
Status: Icebox
Development

No branches or pull requests

4 participants