Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(release): added regression checking and clarifications #1610

Merged
merged 3 commits into from
Mar 17, 2023

Conversation

jm-clius
Copy link
Contributor

This adds some minor clarifications to the release process instructions for contributors:

  • ensuring that CI against js-waku passes against the release candidate
  • clarified the manual process by which the tagged Docker image should be published

Regression check against js-waku.
Clarified Docker image publishing.
Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Great to have this documented.

@@ -56,7 +59,14 @@ git push origin v0.1
### After the release

1. Announce the release on Twitter, Discord and other channels.
2. Deploy the release:
2. Deploy the release image to [Dockerhub](https://hub.docker.com/layers/statusteam/nim-waku/a5f8b9/images/sha256-88691a8f82bd6a4242fa99053a65b7fc4762b23a2b4e879d0f8b578c798a0e09?context=explore) by triggering [the manual Jenkins deployment job]([https://ci.status.im/job/nim-waku/job/deploy-wakuv2-prod/)](https://ci.infra.status.im/job/nim-waku/job/manual/build).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick but looks like doesn't render well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! Thanks. Missed this!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 9275e62

@jm-clius jm-clius merged commit b495dd7 into master Mar 17, 2023
@jm-clius jm-clius deleted the docs/release-process branch March 17, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants