fix: bump libp2p with traffic metrics fix #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jm-clius
approved these changes
Apr 4, 2023
|
Btw, we've not been very consistent with this, but we try to stick to the prefixes defined by semantic commits/conventional commits for commit messages (i.e. |
alrevuelta
changed the title
|
You are very right! Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inlibp2p_network_bytesmetric, used to calculate the incoming bandwidth of the node. Due to this bug, this metric was reporting values of x5 times (or even more) the real bandwidth of the node.libp2p_network_bytesin/outmetrics now match with other ones (provided by cadvisor). So now we should have better obseravbility on the consumed bandwdith on nwaku nodes.Image showing before/after fix. Before, nim-libp2p metrics differed from cadvisor (same pattern but amplified). After 14:05 (see time axis), I deployed with the fix in this PR and the bandwidths now match.
