fix(ci): make experimental default to true in fleet deployment #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not simply change it on the build parameters for the deployments where it's necessary? I think this configuration is transferred to the next deployments? https://ci.infra.status.im/job/nim-waku/job/deploy-wakuv2-test/ If not, we'd have to ensure that it's set to false on prod deployments (e.g. as we're still rolling out the release and want to do so to Status prod fleets). |
|
it isn't transferred to the next deployments afaik, and any merge to master overwrites the flag :/ |
jm-clius
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During the period of rln-relay testnet 3, we will make the experimental flag default to true for all fleet deployments.
Changes
Jenkinsfile.releaseto makeEXPERIMENTALdefault