Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix flaky test for dos topic #1747

Merged
merged 1 commit into from
May 19, 2023
Merged

fix: fix flaky test for dos topic #1747

merged 1 commit into from
May 19, 2023

Conversation

alrevuelta
Copy link
Contributor

Description

  • Fix flaky test for dos topic. Too many messages were being sent, and in some cases the check was done before all the messages were gossiped, hence failing.
  • This is fixed by sending less messages, that should take less time to gossip. If it happens again, plan b is to increase the timeouts.
  • Thanks @rymnc for the report.

@alrevuelta alrevuelta requested a review from rymnc May 19, 2023 10:23
rymnc
rymnc approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alrevuelta alrevuelta merged commit 46e231d into master May 19, 2023
@alrevuelta alrevuelta deleted the fix-test branch May 19, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rymnc rymnc rymnc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alrevuelta @rymnc