Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add experimental builds to nightly #1761

Merged
merged 1 commit into from
May 26, 2023

Conversation

vpavlin
Copy link
Member

@vpavlin vpavlin commented May 26, 2023

Description

As suggested by @rymnc, this PR adds artifacts with EXPERIMENTAL=true for nightly builds

You can see how it looks in the release here: https://github.com/nwaku-test-org/nwaku/releases/tag/nightly

Let me know if you have suggestions for different naming, as I am not 100% sure I like how it looks now:)

Changes

  • refactor how artifact names are generated
  • add experimental variable to matrix
  • add experimental suffix to artifacs where applicable

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this!

@vpavlin vpavlin merged commit ffac776 into master May 26, 2023
@vpavlin vpavlin deleted the feat/nightly-experimental branch May 26, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants