Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Inconsistent testing #1826

Closed
SionoiS opened this issue Jun 27, 2023 · 5 comments · Fixed by #1998
Closed

bug: Inconsistent testing #1826

SionoiS opened this issue Jun 27, 2023 · 5 comments · Fixed by #1998
Assignees
@SionoiS
Labels
bug Something isn't working

Comments

@SionoiS
Copy link
Contributor

SionoiS commented Jun 27, 2023

Problem

Tests fail without code change.

Impact

Very annoying and might lead to us to dismiss failed tests.

To reproduce

git commit --amend until test pass/fail

Expected behavior

Test are solid and only fail due to code changes.

nwaku version/commit hash

52894a8 ✔️
I rebase on top
4fdd0e9 ❌
then I change the commit message
28bf211 ✔️

Additional context

In 4fdd0e9
2 test failed
[FAILED] Messages are relayed between two websocket nodes
[FAILED] Messages relaying fails with non-overlapping transports (TCP or Websockets)
@SionoiS SionoiS added bug Something isn't working track:maintenance labels Jun 27, 2023
@SionoiS SionoiS changed the title bug: bug: Inconsistent testing Jun 27, 2023
@SionoiS
Copy link
Contributor Author

SionoiS commented Jul 19, 2023

Just happened again.

e4c6603 ✔️
then
ddf9737 ⛔

@mfw78 mfw78 mentioned this issue Jul 29, 2023
Closed
@SionoiS
Copy link
Contributor Author

SionoiS commented Aug 1, 2023 •
edited
Loading

Seen this multiple time now.

2023-08-01T14:59:03.8349080Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(592) main
2023-08-01T14:59:03.8349645Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(582) NimMain
2023-08-01T14:59:03.8350165Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(573) PreMain
2023-08-01T14:59:03.8350707Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(157) PreMainInner
2023-08-01T14:59:03.8351346Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(897) atmv2atswaku_relayatstest_wakunode_relaydotnim_Init000
2023-08-01T14:59:03.8351964Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(16) runTestX60gensym347
2023-08-01T14:59:03.8354357Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(15) scenario
2023-08-01T14:59:03.8355053Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(373) futureContinue
2023-08-01T14:59:03.8355551Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(255) scenario
2023-08-01T14:59:03.8356004Z atmv2atswaku_relayatstest_wakunode_relaydotnim_Init000(805) start
2023-08-01T14:59:03.8356484Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(373) futureContinue
2023-08-01T14:59:03.8359821Z atmv2atswaku_relayatstest_wakunode_relaydotnim_Init000(835) start
2023-08-01T14:59:03.8360291Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(324) start
2023-08-01T14:59:03.8361072Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(373) futureContinue
2023-08-01T14:59:03.8361573Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(343) start
2023-08-01T14:59:03.8362432Z /home/runner/work/nwaku/nwaku/vendor/nim-libp2p/libp2p/transports/tcptransport.nim(143) start
2023-08-01T14:59:03.8362963Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(376) futureContinue
2023-08-01T14:59:03.8363610Z /home/runner/work/nwaku/nwaku/vendor/nim-libp2p/libp2p/transports/tcptransport.nim(163) start
2023-08-01T14:59:03.8364023Z ��
2023-08-01T14:59:03.8368372Z s�U(152)              createStreamServer
2023-08-01T14:59:03.8368702Z [[reraised from:
2023-08-01T14:59:03.8369066Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(592) main
2023-08-01T14:59:03.8369569Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(582) NimMain
2023-08-01T14:59:03.8370037Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(573) PreMain
2023-08-01T14:59:03.8371353Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(157) PreMainInner
2023-08-01T14:59:03.8372154Z /home/runner/work/nwaku/nwaku/vendor/nim-unittest2/unittest2.nim(897) atmv2atswaku_relayatstest_wakunode_relaydotnim_Init000
2023-08-01T14:59:03.8372895Z /home/runner/work/nwaku/nwaku/vendor/nim-testutils/testutils/unittests.nim(16) runTestX60gensym347
2023-08-01T14:59:03.8373546Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncloop.nim(1251) waitFor
2023-08-01T14:59:03.8374131Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncloop.nim(269) poll
2023-08-01T14:59:03.8374774Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncfutures2.nim(373) futureContinue
2023-08-01T14:59:03.8375420Z /home/runner/work/nwaku/nwaku/vendor/nim-libp2p/libp2p/switch.nim(350) start
2023-08-01T14:59:03.8375987Z ]]
2023-08-01T14:59:03.8376224Z [[reraised from:
2023-08-01T14:59:03.8377646Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(592) main
2023-08-01T14:59:03.8378175Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(582) NimMain
2023-08-01T14:59:03.8378648Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(573) PreMain
2023-08-01T14:59:03.8379126Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(157) PreMainInner
2023-08-01T14:59:03.8379908Z /home/runner/work/nwaku/nwaku/vendor/nim-unittest2/unittest2.nim(897) atmv2atswaku_relayatstest_wakunode_relaydotnim_Init000
2023-08-01T14:59:03.8380636Z /home/runner/work/nwaku/nwaku/vendor/nim-testutils/testutils/unittests.nim(16) runTestX60gensym347
2023-08-01T14:59:03.8381292Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncloop.nim(1251) waitFor
2023-08-01T14:59:03.8381886Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncloop.nim(269) poll
2023-08-01T14:59:03.8382537Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncfutures2.nim(373) futureContinue
2023-08-01T14:59:03.8383170Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncmacro2.nim(300) start
2023-08-01T14:59:03.8383540Z ]]
2023-08-01T14:59:03.8383777Z [[reraised from:
2023-08-01T14:59:03.8384129Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(592) main
2023-08-01T14:59:03.8385159Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(582) NimMain
2023-08-01T14:59:03.8386700Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(573) PreMain
2023-08-01T14:59:03.8387188Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(157) PreMainInner
2023-08-01T14:59:03.8387947Z /home/runner/work/nwaku/nwaku/vendor/nim-unittest2/unittest2.nim(897) atmv2atswaku_relayatstest_wakunode_relaydotnim_Init000
2023-08-01T14:59:03.8388674Z /home/runner/work/nwaku/nwaku/vendor/nim-testutils/testutils/unittests.nim(16) runTestX60gensym347
2023-08-01T14:59:03.8389360Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncloop.nim(1251) waitFor
2023-08-01T14:59:03.8389944Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncloop.nim(269) poll
2023-08-01T14:59:03.8390599Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncfutures2.nim(373) futureContinue
2023-08-01T14:59:03.8391241Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncmacro2.nim(300) scenario
2023-08-01T14:59:03.8391608Z ]]
2023-08-01T14:59:03.8391843Z [[reraised from:
2023-08-01T14:59:03.8392213Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(592) main
2023-08-01T14:59:03.8392657Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(582) NimMain
2023-08-01T14:59:03.8393606Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(573) PreMain
2023-08-01T14:59:03.8394122Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(157) PreMainInner
2023-08-01T14:59:03.8394884Z /home/runner/work/nwaku/nwaku/vendor/nim-unittest2/unittest2.nim(897) atmv2atswaku_relayatstest_wakunode_relaydotnim_Init000
2023-08-01T14:59:03.8395608Z /home/runner/work/nwaku/nwaku/vendor/nim-testutils/testutils/unittests.nim(16) runTestX60gensym347
2023-08-01T14:59:03.8396302Z ]]
2023-08-01T14:59:03.8396433Z 
2023-08-01T14:59:03.8396635Z     Unhandled exception: (98) Address already in use [LPError]
2023-08-01T14:59:03.8397055Z   [FAILED] Messages are relayed between two websocket nodes

@vpavlin
Copy link
Member

vpavlin commented Aug 1, 2023

I noticed some tests use Port(0) (https://github.com/waku-org/nwaku/blob/master/tests/v2/test_peer_exchange.nim#L26; which, I assume, means use random port?) and some bind to a particular port (https://github.com/waku-org/nwaku/blob/master/tests/v2/test_waku_discv5.nim#L59)

We could get into colisions when using explicit ports with other projects (I am not sure how dedicated the Action runner is), but I am also not sure how parallelization works when running tests in Nim - is it possible that it somehow tries to parallelize the test run to speed it up?

In any case, it might make sense to try to remove all hardcoded ports, if possible as a first attempt to mitigate this, maybe?:)

@SionoiS
Copy link
Contributor Author

SionoiS commented Aug 1, 2023 

2023-08-01T19:17:38.5331144Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(592) main
2023-08-01T19:17:38.5339540Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(582) NimMain
2023-08-01T19:17:38.5340010Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(573) PreMain
2023-08-01T19:17:38.5340493Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(157) PreMainInner
2023-08-01T19:17:38.5366523Z /home/runner/work/nwaku/nwaku/vendor/nim-unittest2/unittest2.nim(897) atmv2atswaku_relayatstest_wakunode_relaydotnim_Init000
2023-08-01T19:17:38.5367322Z /home/runner/work/nwaku/nwaku/vendor/nim-testutils/testutils/unittests.nim(16) runTestX60gensym727
2023-08-01T19:17:38.5367962Z /home/runner/work/nwaku/nwaku/vendor/nim-testutils/testutils/unittests.nim(15) scenario
2023-08-01T19:17:38.5368718Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncfutures2.nim(373) futureContinue
2023-08-01T19:17:38.5369475Z /home/runner/work/nwaku/nwaku/tests/v2/waku_relay/test_wakunode_relay.nim(421) scenario
2023-08-01T19:17:38.5369905Z /home/runner/work/nwaku/nwaku/waku/v2/node/waku_node.nim(788) start
2023-08-01T19:17:38.5370508Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncfutures2.nim(373) futureContinue
2023-08-01T19:17:38.5370962Z /home/runner/work/nwaku/nwaku/waku/v2/node/waku_node.nim(818) start
2023-08-01T19:17:38.5371646Z /home/runner/work/nwaku/nwaku/vendor/nim-libp2p/libp2p/switch.nim(324) start
2023-08-01T19:17:38.5372293Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncfutures2.nim(373) futureContinue
2023-08-01T19:17:38.5373517Z /home/runner/work/nwaku/nwaku/vendor/nim-libp2p/libp2p/switch.nim(343) start
2023-08-01T19:17:38.5374155Z /home/runner/work/nwaku/nwaku/vendor/nim-libp2p/libp2p/transports/tcptransport.nim(143) start
2023-08-01T19:17:38.5375147Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncfutures2.nim(376) futureContinue
2023-08-01T19:17:38.5375821Z /home/runner/work/nwaku/nwaku/vendor/nim-libp2p/libp2p/transports/tcptransport.nim(163) start
2023-08-01T19:17:38.5376461Z /home/runner/work/nwaku/nwaku/vendor/nim-libp2p/libp2p/wire.nim(152) createStreamServer
2023-08-01T19:17:38.5376840Z [[reraised from:
2023-08-01T19:17:38.5377212Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(592) main
2023-08-01T19:17:38.5377673Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(582) NimMain
2023-08-01T19:17:38.5378141Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(573) PreMain
2023-08-01T19:17:38.5378770Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(157) PreMainInner
2023-08-01T19:17:38.5379495Z /home/runner/work/nwaku/nwaku/vendor/nim-unittest2/unittest2.nim(897) atmv2atswaku_relayatstest_wakunode_relaydotnim_Init000
2023-08-01T19:17:38.5381210Z /home/runner/work/nwaku/nwaku/vendor/nim-testutils/testutils/unittests.nim(16) runTestX60gensym727
2023-08-01T19:17:38.5381863Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncloop.nim(1251) waitFor
2023-08-01T19:17:38.5382468Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncloop.nim(269) poll
2023-08-01T19:17:38.5383115Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncfutures2.nim(373) futureContinue
2023-08-01T19:17:38.5383731Z /home/runner/work/nwaku/nwaku/vendor/nim-libp2p/libp2p/switch.nim(350) start
2023-08-01T19:17:38.5384079Z ]]
2023-08-01T19:17:38.5384409Z [[reraised from:
2023-08-01T19:17:38.5384752Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(592) main
2023-08-01T19:17:38.5385188Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(582) NimMain
2023-08-01T19:17:38.5385613Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(573) PreMain
2023-08-01T19:17:38.5386064Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(157) PreMainInner
2023-08-01T19:17:38.5386733Z /home/runner/work/nwaku/nwaku/vendor/nim-unittest2/unittest2.nim(897) atmv2atswaku_relayatstest_wakunode_relaydotnim_Init000
2023-08-01T19:17:38.5387386Z /home/runner/work/nwaku/nwaku/vendor/nim-testutils/testutils/unittests.nim(16) runTestX60gensym727
2023-08-01T19:17:38.5387974Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncloop.nim(1251) waitFor
2023-08-01T19:17:38.5388527Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncloop.nim(269) poll
2023-08-01T19:17:38.5389115Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncfutures2.nim(373) futureContinue
2023-08-01T19:17:38.5389903Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncmacro2.nim(300) start
2023-08-01T19:17:38.5390267Z ]]
2023-08-01T19:17:38.5390488Z [[reraised from:
2023-08-01T19:17:38.5390850Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(592) main
2023-08-01T19:17:38.5391314Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(582) NimMain
2023-08-01T19:17:38.5391777Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(573) PreMain
2023-08-01T19:17:38.5392248Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(157) PreMainInner
2023-08-01T19:17:38.5392960Z /home/runner/work/nwaku/nwaku/vendor/nim-unittest2/unittest2.nim(897) atmv2atswaku_relayatstest_wakunode_relaydotnim_Init000
2023-08-01T19:17:38.5393667Z /home/runner/work/nwaku/nwaku/vendor/nim-testutils/testutils/unittests.nim(16) runTestX60gensym727
2023-08-01T19:17:38.5394305Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncloop.nim(1251) waitFor
2023-08-01T19:17:38.5394912Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncloop.nim(269) poll
2023-08-01T19:17:38.5397013Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncfutures2.nim(373) futureContinue
2023-08-01T19:17:38.5397942Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncmacro2.nim(300) scenario
2023-08-01T19:17:38.5398313Z ]]
2023-08-01T19:17:38.5398537Z [[reraised from:
2023-08-01T19:17:38.5398905Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(592) main
2023-08-01T19:17:38.5399364Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(582) NimMain
2023-08-01T19:17:38.5399834Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(573) PreMain
2023-08-01T19:17:38.5400307Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(157) PreMainInner
2023-08-01T19:17:38.5401025Z /home/runner/work/nwaku/nwaku/vendor/nim-unittest2/unittest2.nim(897) atmv2atswaku_relayatstest_wakunode_relaydotnim_Init000
2023-08-01T19:17:38.5401861Z /home/runner/work/nwaku/nwaku/vendor/nim-testutils/testutils/unittests.nim(16) runTestX60gensym727
2023-08-01T19:17:38.5402246Z ]]
2023-08-01T19:17:38.5402385Z 
2023-08-01T19:17:38.5402586Z     Unhandled exception: (98) Address already in use [LPError]
2023-08-01T19:17:38.5403101Z   [FAILED] Messages are relayed between nodes with multiple transports (websocket and secure Websockets)

and also

2023-08-01T19:17:32.5122024Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(592) main
2023-08-01T19:17:32.5122723Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(582) NimMain
2023-08-01T19:17:32.5123683Z /home/runner/work/nwaku/nwaku/vendor/nim-unittest2/unittest2.nim(573) PreMain
2023-08-01T19:17:32.5124420Z /home/runner/work/nwaku/nwaku/vendor/nim-unittest2/unittest2.nim(157) PreMainInner
2023-08-01T19:17:32.5125315Z /home/runner/work/nwaku/nwaku/vendor/nim-testutils/testutils/unittests.nim(897) atmv2atswaku_relayatstest_wakunode_relaydotnim_Init000
2023-08-01T19:17:32.5126222Z /home/runner/work/nwaku/nwaku/vendor/nim-testutils/testutils/unittests.nim(16) runTestX60gensym539
2023-08-01T19:17:32.5127024Z /home/runner/work/nwaku/nwaku/vendor/nim-testutils/testutils/unittests.nim(15) scenario
2023-08-01T19:17:32.5127872Z /home/runner/work/nwaku/nwaku/vendor/nim-testutils/testutils/unittests.nim(373) futureContinue
2023-08-01T19:17:32.5128654Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncfutures2.nim(337) scenario
2023-08-01T19:17:32.5129641Z atmv2atswaku_relayatstest_wakunode_relaydotnim_Init000(788) start
2023-08-01T19:17:32.5130398Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncfutures2.nim(373) futureContinue
2023-08-01T19:17:32.5130977Z atmv2atswaku_relayatstest_wakunode_relaydotnim_Init000(818) start
2023-08-01T19:17:32.5131683Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncfutures2.nim(324) start
2023-08-01T19:17:32.5132458Z /home/runner/work/nwaku/nwaku/vendor/nim-testutils/testutils/unittests.nim(373) futureContinue
2023-08-01T19:17:32.5133217Z /home/runner/work/nwaku/nwaku/vendor/nim-testutils/testutils/unittests.nim(343) start
2023-08-01T19:17:32.5134011Z /home/runner/work/nwaku/nwaku/vendor/nim-libp2p/libp2p/transports/tcptransport.nim(143) start
2023-08-01T19:17:32.5138743Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(376) futureContinue
2023-08-01T19:17:32.5139523Z /home/runner/work/nwaku/nwaku/vendor/nim-libp2p/libp2p/transports/tcptransport.nim(163) start
2023-08-01T19:17:32.5140172Z �gr�RV(152)              createStreamServer
2023-08-01T19:17:32.5140535Z [[reraised from:
2023-08-01T19:17:32.5165274Z /home/runner/work/nwaku/nwaku/vendor/nim-testutils/testutils/unittests.nim(592) main
2023-08-01T19:17:32.5166036Z /home/runner/work/nwaku/nwaku/vendor/nim-testutils/testutils/unittests.nim(582) NimMain
2023-08-01T19:17:32.5166755Z /home/runner/work/nwaku/nwaku/vendor/nim-unittest2/unittest2.nim(573) PreMain
2023-08-01T19:17:32.5167322Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(157) PreMainInner
2023-08-01T19:17:32.5167990Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(897) atmv2atswaku_relayatstest_wakunode_relaydotnim_Init000
2023-08-01T19:17:32.5168687Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(16) runTestX60gensym539
2023-08-01T19:17:32.5169421Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(15) scenario
2023-08-01T19:17:32.5170493Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(373) futureContinue
2023-08-01T19:17:32.5171086Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(337) scenario
2023-08-01T19:17:32.5171615Z /home/runner/work/nwaku/nwaku/waku/v2/node/waku_node.nim(788) start
2023-08-01T19:17:32.5172149Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(373) futureContinue
2023-08-01T19:17:32.5172691Z /home/runner/work/nwaku/nwaku/waku/v2/node/waku_node.nim(818) start
2023-08-01T19:17:32.5173216Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(324) start
2023-08-01T19:17:32.5173850Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(376) futureContinue
2023-08-01T19:17:32.5174597Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(350) start
2023-08-01T19:17:32.5174938Z ]]
2023-08-01T19:17:32.5175163Z [[reraised from:
2023-08-01T19:17:32.5175540Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(592) main
2023-08-01T19:17:32.5176004Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(582) NimMain
2023-08-01T19:17:32.5176466Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(573) PreMain
2023-08-01T19:17:32.5176948Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(157) PreMainInner
2023-08-01T19:17:32.5177718Z /home/runner/work/nwaku/nwaku/vendor/nim-unittest2/unittest2.nim(897) atmv2atswaku_relayatstest_wakunode_relaydotnim_Init000
2023-08-01T19:17:32.5178438Z /home/runner/work/nwaku/nwaku/vendor/nim-testutils/testutils/unittests.nim(16) runTestX60gensym539
2023-08-01T19:17:32.5179094Z /home/runner/work/nwaku/nwaku/vendor/nim-testutils/testutils/unittests.nim(15) scenario
2023-08-01T19:17:32.5179761Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncfutures2.nim(373) futureContinue
2023-08-01T19:17:32.5180286Z /home/runner/work/nwaku/nwaku/tests/v2/waku_relay/test_wakunode_relay.nim(337) scenario
2023-08-01T19:17:32.5180753Z /home/runner/work/nwaku/nwaku/waku/v2/node/waku_node.nim(788) start
2023-08-01T19:17:32.5181367Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncfutures2.nim(376) futureContinue
2023-08-01T19:17:32.5184574Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncmacro2.nim(300) start
2023-08-01T19:17:32.5184947Z ]]
2023-08-01T19:17:32.5185186Z [[reraised from:
2023-08-01T19:17:32.5185555Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(592) main
2023-08-01T19:17:32.5189803Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(582) NimMain
2023-08-01T19:17:32.5193019Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(573) PreMain
2023-08-01T19:17:32.5193500Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(157) PreMainInner
2023-08-01T19:17:32.5194240Z /home/runner/work/nwaku/nwaku/vendor/nim-unittest2/unittest2.nim(897) atmv2atswaku_relayatstest_wakunode_relaydotnim_Init000
2023-08-01T19:17:32.5194985Z /home/runner/work/nwaku/nwaku/vendor/nim-testutils/testutils/unittests.nim(16) runTestX60gensym539
2023-08-01T19:17:32.5198670Z /home/runner/work/nwaku/nwaku/vendor/nim-testutils/testutils/unittests.nim(15) scenario
2023-08-01T19:17:32.5199330Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncfutures2.nim(376) futureContinue
2023-08-01T19:17:32.5203347Z /home/runner/work/nwaku/nwaku/vendor/nim-chronos/chronos/asyncmacro2.nim(300) scenario
2023-08-01T19:17:32.5203700Z ]]
2023-08-01T19:17:32.5203940Z [[reraised from:
2023-08-01T19:17:32.5208110Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(592) main
2023-08-01T19:17:32.5208581Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(582) NimMain
2023-08-01T19:17:32.5209263Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(573) PreMain
2023-08-01T19:17:32.5209755Z /home/runner/work/nwaku/nwaku/waku/v2/waku_rln_relay/rln_relay.nim(157) PreMainInner
2023-08-01T19:17:32.5213961Z /home/runner/work/nwaku/nwaku/vendor/nim-unittest2/unittest2.nim(897) atmv2atswaku_relayatstest_wakunode_relaydotnim_Init000
2023-08-01T19:17:32.5214830Z /home/runner/work/nwaku/nwaku/vendor/nim-testutils/testutils/unittests.nim(16) runTestX60gensym539
2023-08-01T19:17:32.5215223Z ]]
2023-08-01T19:17:32.5215365Z 
2023-08-01T19:17:32.5215568Z     Unhandled exception: (98) Address already in use [LPError]
2023-08-01T19:17:32.5216166Z   [FAILED] Messages relaying fails with non-overlapping transports (TCP or Websockets)

@Ivansete-status Ivansete-status mentioned this issue Aug 30, 2023
Merged
@SionoiS SionoiS self-assigned this Sep 6, 2023
@SionoiS
Copy link
Contributor Author

SionoiS commented Sep 6, 2023

Ran into #1883

Seams like Port(0) does not really pick a random port everywhere (chronos http server for example).

Maybe the best would be to add a randomPort() func?

@SionoiS SionoiS mentioned this issue Sep 6, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SionoiS SionoiS

Labels
bug Something isn't working
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tests): relay tests use random port to avoid conflict waku-org/nwaku
3 participants
@vpavlin @SionoiS @fryorcraken