Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rln-relay): mark duplicated messages as spam #1867

Merged
merged 2 commits into from
Aug 2, 2023
Merged

fix(rln-relay): mark duplicated messages as spam #1867

merged 2 commits into from
Aug 2, 2023

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Jul 31, 2023 •
edited
Loading

Description

If we have the same externalNullifier and proofMetadata, and same share_x and share_y we should mark the message as spam.

Changes

  • Marks duplicated messages with the same proof as spam

Issue

closes #1862

@rymnc rymnc added the track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications label Jul 31, 2023
@rymnc rymnc self-assigned this Jul 31, 2023
@rymnc rymnc requested a review from richard-ramos July 31, 2023 07:02
@rymnc rymnc marked this pull request as ready for review July 31, 2023 09:33
@vpavlin
Copy link
Member

vpavlin commented Aug 1, 2023

Is the description of the hasDuplicate function still correct with this change?

vpavlin
vpavlin approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@vpavlin vpavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change makes sense, just consider updating the description of the function

@rymnc
Copy link
Contributor Author

rymnc commented Aug 1, 2023

The change makes sense, just consider updating the description of the function

Addressed in 54c1d9c, thanks!

@rymnc rymnc merged commit 4756ccc into master Aug 2, 2023
13 checks passed
@rymnc rymnc deleted the fix-dup-message-validation branch August 2, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpavlin vpavlin vpavlin approved these changes

@richard-ramos richard-ramos richard-ramos approved these changes

Assignees

@rymnc rymnc

Labels
track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(rln-relay): duplicated messages within same epoch
3 participants
@rymnc @vpavlin @richard-ramos