fix: check nil before calling clearTimer #1869
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When setting up RPC server failed and a clean up process started, Filter v2 protocol attempted to call
clearTimer
on uninitialized attribute which causedSIGSEGV: Illegal storage access. (Attempt to read from nil?)
Changes
maintenanceTask
is Nil before callingclearTimer
How to test
wakunode2
from this PR and run it instead - you will get the actual error log and the clean up runs normallyIssue
closes #1866