fix(rln-relay): should error out on rln-relay mount failure

[rymnc]

Description

Previously, we would let the node continue as usualy if the rln-relay failed to mount ~ this PR addresses that issue by bubbling up
the error to the setupProtocols proc in wakunode2.nim

Thanks @alrevuelta for the suggestion

Changes

• Raises an exception instead of error logging on mount failure

Maybe we should convert all the mounting procs to return a result instead of raising exceptions?

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:1904

[alrevuelta]

Thanks for this! Its indeed very important to crash the node if rln was not configured properly and don't continue running the node.

Maybe we should convert all the mounting procs to return a result instead of raising exceptions?

Don't have a strong opinion on this. Guess its matter on where you draw the line between: till here is Result and from here is exception. Not a blocker for this PR I assume?

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:1904

[vpavlin]

I would agree this is a good start and we should do an "analysis" of where wakunode should fail and where it is safe to continue