chore(ci): enable experimental for the PR image builds #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
reviewed
Aug 31, 2023
Comment on lines
+43
to
+45
| EXPERIMENTAL=${{ inputs.experimental }} | ||
|
|
||
| make -j${NPROC} V=1 QUICK_AND_DIRTY_COMPILER=1 NIMFLAGS="-d:disableMarchNative" wakunode2 EXPERIMENTAL=${{EXPERIMENTAL}} |
There was a problem hiding this comment.
curious if we can have this workflow depend on the build job in the ci workflow
we can probably skip the docker image building if the ci workflow fails, right?
There was a problem hiding this comment.
We could, my thinking initially was to provide the image ASAP rather than wait for the CI to finish, but we definitely can change that
vpavlin
force-pushed
the
chore/pr-image-build-improvement
branch
from
c26560d
to
c71db4a
Compare
Ivansete-status
approved these changes
Sep 4, 2023
|
|
||
| build-docker-image: | ||
| needs: changes | ||
| if: ${{ needs.changes.outputs.v2 == 'true' || needs.changes.outputs.common == 'true' || needs.changes.outputs.docker == 'true' }} |
There was a problem hiding this comment.
Is is needed to add the next snippet in the "filter change detection" above?
docker:
- 'docker/**'
There was a problem hiding this comment.
Ah, yes, I added that for the ci, but not for the ci-experimental, good catch
vpavlin
force-pushed
the
chore/pr-image-build-improvement
branch
from
c71db4a
to
f61e03e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spliting out the container image build into a separate workflow and invoking it from both
ciandci-experimental. This results in 2 images being pushed -${PR_NUMBER}and${PR_NUMBER}-experimental- thought it might be useful with regards to the push on RLN latelyChanges
container-image.ymlworkflowciandci-experimentalworkflows