Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rln-relay): apt log levels for certain logs #1986

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Sep 4, 2023

Description

Removes some duplicated logs, used appropriate log levels for some

Changes

  • Removed duplicated validation logs
  • Used appropriate warn log levels, and trace log levels

Issue

Addresses a part of #1906

@rymnc rymnc self-assigned this Sep 4, 2023
Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rymnc rymnc marked this pull request as ready for review September 4, 2023 10:54
@rymnc
Copy link
Contributor Author

rymnc commented Sep 4, 2023

err @vpavlin is ci not running?
"failed at startup"

@vpavlin
Copy link
Member

vpavlin commented Sep 4, 2023

@rymnc Can you force push? It should be fixed now

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:1986

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

You can find the experimental image built from this PR at

quay.io/wakuorg/nwaku-pr:1986-experimental

@rymnc
Copy link
Contributor Author

rymnc commented Sep 4, 2023

@rymnc Can you force push? It should be fixed now

thank you ser

@rymnc rymnc merged commit 97a7c9d into master Sep 4, 2023
14 checks passed
@rymnc rymnc deleted the fix-logs-rln branch September 4, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants