Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: DB user_version is not set on database init #2036

Closed
vpavlin opened this issue Sep 14, 2023 · 1 comment
Closed

bug: DB user_version is not set on database init #2036

vpavlin opened this issue Sep 14, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@vpavlin
Copy link
Member

vpavlin commented Sep 14, 2023

Problem

We are currently not setting user_version (AKA schema version) on DB initialization. This results in migration issues, which we are currently working around using the code in #2031

Impact

After the temporary fix applied in #2031, we should not get in trouble for now, but we need to revisit this and fix it properly - i.e. initialize the user_version to the correct schema version

To reproduce

If you can reproduce the behavior, steps to reproduce:

  1. Run a fresh wakunode2
  2. Check the user_version in DB

Expected behavior

user_version in DB matches the value in code

nwaku version/commit hash

State the version of nwaku where you've encountered the bug or, if built off a specific commit, the relevant commit hash. You can check the version by running ./wakunode2 --version.

  • all versions up to v0.20.0 (included)

Additional context

Add any other context about the problem here.

@vpavlin vpavlin added the bug Something isn't working label Sep 14, 2023
@chair28980
Copy link
Contributor

Per discussion during nwaku pm 2024-01-02, closing issue as we will likely store the schema version within a separate table, per @richard-ramos suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants