Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sharding terminology & cluster id #2104

Merged
merged 4 commits into from
Oct 5, 2023
Merged

fix: sharding terminology & cluster id #2104

merged 4 commits into from
Oct 5, 2023

Conversation

SionoiS
Copy link
Contributor

@SionoiS SionoiS commented Oct 3, 2023

Fix #2102

@SionoiS SionoiS self-assigned this Oct 3, 2023
@github-actions
Copy link

github-actions bot commented Oct 3, 2023 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2104

Built from ad97bd8

alrevuelta
alrevuelta approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! couple of minor things.

tests/test_waku_discv5.nim Outdated Show resolved Hide resolved
tests/test_waku_discv5.nim Outdated Show resolved Hide resolved
Ivansete-status
Ivansete-status approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@SionoiS SionoiS merged commit a47dc9e into master Oct 5, 2023
10 checks passed
@SionoiS SionoiS deleted the fix--sharding-terminology branch October 5, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansete-status Ivansete-status Ivansete-status approved these changes

@alrevuelta alrevuelta alrevuelta approved these changes

Assignees

@SionoiS SionoiS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: project wide consistent sharding terminology
3 participants
@SionoiS @alrevuelta @Ivansete-status