Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: HTTP REST API: Private API #2227

Closed
NagyZoltanPeter opened this issue Nov 17, 2023 · 4 comments
Closed

feat: HTTP REST API: Private API #2227

NagyZoltanPeter opened this issue Nov 17, 2023 · 4 comments
Labels
E:REST API service node See https://github.com/waku-org/pm/issues/82 for details

Comments

@NagyZoltanPeter
Copy link
Contributor

Problem

Formerly as being part of cover issue: #1076
That has been closed with implemented achievements while missing Private Rest API implemented.

This issue is to continue tracking implementation of nim waku /private api.

@NagyZoltanPeter NagyZoltanPeter added the E:REST API service node See https://github.com/waku-org/pm/issues/82 for details label Nov 17, 2023
@alrevuelta
Copy link
Contributor

alrevuelta commented Feb 12, 2024

@NagyZoltanPeter Mind elaborating on whats missing here? And what is expected to be in private? You mean like "relay private API"?
cc @Ivansete-status

@NagyZoltanPeter
Copy link
Contributor Author

@NagyZoltanPeter Mind elaborating on whats missing here? And what is expected to be in private? You mean like "relay private API"? cc @Ivansete-status

I remember it was not clearly specified, more a placeholder like.
@jm-clius : Can you clearify?

@jm-clius
Copy link
Contributor

Yes, this would have been the REST equivalent of the Relay Private API. The sole purpose of that API was to private encryption/decryption of Waku v1 payloads (and to relay such encrypted messages). We've deprioritised Waku v1 <> v2 compatibility and this functionality is not used in JSON RPC. In future something like this API could be used for Noise payloads, but this is not priority. I'd suggest closing this issue for now.

@NagyZoltanPeter
Copy link
Contributor Author

Yes, this would have been the REST equivalent of the Relay Private API. The sole purpose of that API was to private encryption/decryption of Waku v1 payloads (and to relay such encrypted messages). We've deprioritised Waku v1 <> v2 compatibility and this functionality is not used in JSON RPC. In future something like this API could be used for Noise payloads, but this is not priority. I'd suggest closing this issue for now.

I agree to close it!
cc: @chair28980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:REST API service node See https://github.com/waku-org/pm/issues/82 for details
Projects
Archived in project
Development

No branches or pull requests

3 participants