Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cbindings allow mounting the Store protocol from libwaku #2276

Merged
merged 6 commits into from
Dec 11, 2023

Conversation

Ivansete-status
Copy link
Collaborator

@Ivansete-status Ivansete-status commented Dec 8, 2023

Description

Allows to mount Store in the node started from libwaku. With that PR, the node can receive the following configuration items as a parameter:

{
      "store": 1,
      "storeDbUrl": "postgres://postgres:test123@localhost:5432/postgres",
      "storeRetentionPolicy": "time:6000000",
      "storeMaxNumDbConnections": 30
}

In upcoming PRs, we will introduce pending changes to allow the "self" node to make requests to other Store nodes, and we will introduce an additional API function for that: waku_store_query(char* queryJSON, char* peerID, int ms, WakuCallBack cb, void* userData);

Note: ignore the library/waku_thread/inter_thread_communication/requests/protocols/store_request.nim for now. It will be completed shortly.

Changes

  • Allow mount Store protocol from libwaku-cbindings
  • Extend the C example to mount Store in the "self" node.
  • Move the WakuCallBack definition in a separate file, library/callback.nim

@Ivansete-status Ivansete-status self-assigned this Dec 8, 2023
Copy link

github-actions bot commented Dec 8, 2023

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2276

Built from f96c218

@Ivansete-status Ivansete-status marked this pull request as ready for review December 8, 2023 10:24
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@Ivansete-status Ivansete-status merged commit 28142f4 into master Dec 11, 2023
13 of 14 checks passed
@Ivansete-status Ivansete-status deleted the cbindings-store-new branch December 11, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants