-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(rln_db_inspector): include in wakunode2 binary #2292
Conversation
This PR may contain changes to configuration options of one of the apps. If you are introducing a breaking change (i.e. the set of options in latest release would no longer be applicable) make sure the original option is preserved with a deprecation note for 2 following releases before it is actually removed. Please also make sure the label |
You can find the image built from this PR at
Built from b026693 |
8726fbd
to
a5c85b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment but lgtm
apps/wakunode2/external_config.nim
Outdated
@@ -30,9 +30,12 @@ type ProtectedTopic* = object | |||
topic*: string | |||
key*: secp256k1.SkPublicKey | |||
|
|||
proc noop() = discard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still a wip, need to figure out how we can have a command for wakunode2 which doesn't accept additional args, see my message here - https://discord.com/channels/1110799176264056863/1151319265694199829/1184765875329433681
While I understand this approach is followed by famous apps/projects such as Geth, Docker, Git, etc., I think for now it is better to have the tools separated. It sounds a bit weird to me having to use it with something like: imo, I think it would be better to have the following subcommand set:
*** Notice that I've added a line for to the current tools that we are packaging (wakucanary and networkmonitor.) My suggestion is to postpone that wdyt @alrevuelta @rymnc @jm-clius @NagyZoltanPeter @gabrielmer @SionoiS? Also, very important to align this approach with |
@Ivansete-status Tools such as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve as I don't want to be a blocker
Description
This PR includes the rln-db-inspector tool within the wakunode2 binary for ease of use.
Changes
external_config.nim
, andnim.cfg
proc
ifies the rln_db_inspector for use with wakunode2inspectRlnDb
command to wakunode2How to test
First, we compile the binary
This command will fetch the rln static library and link it automatically.
Define the arguments you wish to use
Run the db inspector
./build/wakunode2 inspectRlnDb \ --rln-relay-tree-path:$RLN_TREE_DB_PATH
What this does is -
a. loads the tree db from the path provided
b. Logs out the metadata, including, number of leaves set, past 5 merkle roots, last synced block number